Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument fitVertices to output more information when failing assert (issue cms-sw/cmssw#44923) #45630

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 5, 2024

PR description:

Title says it all, as per #44923 (comment)

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported for 2024 data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Aug 5, 2024

urgent

@mmusich
Copy link
Contributor Author

mmusich commented Aug 5, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • RecoTracker/PixelVertexFinding (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24eaa1/40753/summary.html
COMMIT: 2055459
CMSSW: CMSSW_14_1_X_2024-08-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45630/40753/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 88 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3530500
  • DQMHistoTests: Total failures: 2464
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528016
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 200 log files, 170 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 6a0edc7 into cms-sw:master Aug 5, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_44923 branch August 5, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants